Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support usage of consistency parameter #381

Merged
merged 6 commits into from
Sep 6, 2024
Merged

feat: support usage of consistency parameter #381

merged 6 commits into from
Sep 6, 2024

Conversation

ewanharris
Copy link
Member

Description

Adds support for the --consistency parameter to the query commands to allow usage of that feature.

For more details see the relevant openfga/openfga PR.

References

Closes #379

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners August 30, 2024 10:27
@stacklok-cloud Stacklok Cloud
Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 07e6b367:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

rhamzeh
rhamzeh previously approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you think we can add this to the README (in a follow-up PR is OK)

@ewanharris
Copy link
Member Author

@rhamzeh, is there anything in addition to the existing changes that I forgot?

@rhamzeh
Copy link
Member

rhamzeh commented Sep 2, 2024

@ewanharris sorry I meant if we can add that to the examples in the command - not the readme.

e.g.

@ewanharris ewanharris marked this pull request as draft September 2, 2024 16:10
@ewanharris
Copy link
Member Author

Putting into draft to avoid merging as currently missing the fga tuple read command support

@ewanharris ewanharris marked this pull request as ready for review September 2, 2024 16:28
@ewanharris ewanharris changed the title feat(query): support usage of consistency parameter feat: support usage of consistency parameter Sep 3, 2024
@jimmyjames jimmyjames added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit cc70665 Sep 6, 2024
16 checks passed
@jimmyjames jimmyjames deleted the feat/379-consistency branch September 6, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames left review comments

@aaguiarz aaguiarz aaguiarz left review comments

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for --consistency parameter in queries
4 participants
@ewanharris @rhamzeh @jimmyjames @aaguiarz